Skip to content

Enable adding columns in auto migrations in schema crate#2956

Merged
Shubham8287 merged 5 commits into
masterfrom
jgilles/add_columns
Aug 20, 2025
Merged

Enable adding columns in auto migrations in schema crate#2956
Shubham8287 merged 5 commits into
masterfrom
jgilles/add_columns

Conversation

@kazimuth
Copy link
Copy Markdown
Contributor

Description of Changes

This adds auto migration support to the schema crate.
Additional changes are needed to fully implement this feature: see #2912

API and ABI breaking changes

None

Expected complexity level and risk

1, at this level the change is fairly straightforward. The integration will be more difficult.

Testing

Added schema unit tests for success/failure cases.

@kazimuth kazimuth requested review from Centril and Shubham8287 July 18, 2025 17:22
@bfops bfops added the release-any To be landed in any release window label Jul 21, 2025
@Shubham8287 Shubham8287 force-pushed the jgilles/add_columns branch from 5268953 to 1814483 Compare July 23, 2025 08:08
Comment thread crates/bindings/tests/ui/tables.stderr
@Shubham8287 Shubham8287 force-pushed the jgilles/add_columns branch from 1814483 to 364e617 Compare July 23, 2025 10:54
Comment thread crates/core/src/db/update.rs Outdated
Comment thread crates/lib/src/db/raw_def/v9.rs Outdated
Comment thread crates/lib/src/db/raw_def/v9.rs Outdated
Comment thread crates/sats/src/buffer.rs
Comment thread crates/lib/src/db/raw_def/v9.rs Outdated
Comment thread crates/schema/src/def/validate/v9.rs Outdated
Comment thread crates/schema/src/def/validate/v9.rs Outdated
Comment thread crates/schema/src/def/validate/v9.rs Outdated
Comment thread crates/schema/src/error.rs
Comment thread crates/schema/src/error.rs
@Shubham8287 Shubham8287 force-pushed the jgilles/add_columns branch 3 times, most recently from 075fa8f to 165df33 Compare August 11, 2025 16:37
Comment thread crates/schema/src/def/validate/v9.rs Outdated
Comment thread crates/schema/src/def.rs Outdated
Comment thread crates/schema/src/def/validate/v9.rs
Comment thread crates/lib/src/db/raw_def/v9.rs Outdated
@Centril Centril self-assigned this Aug 12, 2025
Comment thread crates/lib/src/db/raw_def/v9.rs Outdated
@Shubham8287 Shubham8287 requested a review from Centril August 13, 2025 17:10
@Shubham8287
Copy link
Copy Markdown
Contributor

@Centril , Do you expect me to do anything else in this PR?

@Centril
Copy link
Copy Markdown
Contributor

Centril commented Aug 19, 2025

@Centril , Do you expect me to do anything else in this PR?

If you could please address this: #2956 (comment)
But in the interest of time, it can be done in a follow up.

@Shubham8287 Shubham8287 enabled auto-merge August 20, 2025 07:32
@Shubham8287 Shubham8287 added this pull request to the merge queue Aug 20, 2025
Merged via the queue into master with commit f274414 Aug 20, 2025
25 checks passed
@Shubham8287 Shubham8287 deleted the jgilles/add_columns branch August 20, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants